quarkiverse / quarkus-openapi-generator

OpenAPI Generator - REST Client Generator
Apache License 2.0
119 stars 80 forks source link

POC: error when input/openapi has cookies #681

Closed ru4ert closed 6 months ago

ru4ert commented 6 months ago

Expected Result:

    @GET
    @Path("/findByStatus")
    @Produces({"application/xml", "application/json"})
    @GeneratedMethod ("findPetsByStatus")
    public List<Pet> findPetsByStatus(
        @CookieParam("example-cookie") String exampleCookie, 
        @GeneratedParam("status") @QueryParam("status") String status
    ); 

Actual output:

    @GET
    @Path("/findByStatus")
    @Produces({"application/xml", "application/json"})
    @GeneratedMethod ("findPetsByStatus")
    public List<Pet> findPetsByStatus(
        , 
        @GeneratedParam("status") @QueryParam("status") String status
    );

Cannot address the origin of this error. Any thoughts?

github-actions[bot] commented 6 months ago

🎊 PR Preview e91887ff10b000643ebeeada904e0b7932a6aecc has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-681.surge.sh

ricardozanini commented 6 months ago

@ru4ert I believe you should take a look at the api.qute template file and see how we are handling these parameters there.

ru4ert commented 6 months ago

@ricardozanini Should i add tests/docu?

ricardozanini commented 6 months ago

@ricardozanini Should i add tests/docu?

Sure thing! :)

ricardozanini commented 6 months ago

@ru4ert let me know when this is ready for review!

ru4ert commented 6 months ago

@ru4ert i think you can review it. If you have CRs i will apply them later then

hbelmiro commented 6 months ago

@all-contributors add @ru4ert for code, tests, and docs.

allcontributors[bot] commented 6 months ago

@hbelmiro

I've put up a pull request to add @ru4ert! :tada:

ru4ert commented 6 months ago

@hbelmiro Thanks for the merge! Can you create a minor release?

ricardozanini commented 6 months ago

~@ru4ert I'm on it.~

EDIT: @hbelmiro was faster :)