Closed lizzyTheLizard closed 5 months ago
Hi @hbelmiro! I did not understand how the integration-tests were triggered, not this should be fixed...
🎊 PR Preview 4cde6cafb57aa09c359781bbccd764330f8973d5 has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-701.surge.sh
@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR.
@ricardozanini is this approval really needed? We could be more agile by removing it.
@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR.
@ricardozanini is this approval really needed? We could be more agile by removing it.
This is needed for security reasons for first time contributors
@lizzyTheLizard they need to be manually started by one of the maintainers in the contributor’s first PR. @ricardozanini is this approval really needed? We could be more agile by removing it.
This is needed for security reasons for first time contributors
Yes, I agree it makes sense having them, we have them in Apicurio as well.
@lizzyTheLizard can u rebase?
@ricardozanini: Done
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
I have added the possibility to use YAML Specifications for server side. As Apicurio only supports JSON, YAML-Files are converted to JSON on the fly. As the documentation for server-side was quite wrong, I changed it accordingly, even though there is already another PR https://github.com/quarkiverse/quarkus-openapi-generator/pull/689 fixing #686 open that will be redundant now.
While handling this, I directly added the possibility to change the base folder. Up to now, all specs are taken from 'resources/openapi', now you can overwrite this with a property as hinted incorrectly by the docs. => This is not directly related to #693, but I thought that property document the current state. I hope it is fine that I added this to this PR directly.