Closed raffaelespazzoli closed 1 year ago
This client uses HTTP not GRPC; OpenFGA supports both.
I see. GRPC is supposedly more performant, would it be possible to implement that client type as an option? Either way exposing all of the ports should no be an issue.
Yes, we should be exposing all the ports.
As far as HTTP vs GRCP, HTTP is dramatically simpler to implement. Also, a single 3 item JSON map request and a boolean result is transmitted for the check
operation; which is what is required to be performant.
I plan on ensuring we are connecting with HTTP/2 (which is also what gRPC uses) and probably leave it there for a while.
@kdubb: I am half way through adding grpc support. The question is should we completely switch or provide both options?
I'm not sure. No reason to maintain something nobody ever uses. Then again, maybe somebody cannot run gRPC and need the HTTP client.
currently the dev container expose 8080 which is the http port. But the client uses grpc (8081), is that going to work? also the playground port (3000) is very useful for troubleshooting. All three ports should be expose to the host by the dev container.