quarkiverse / quarkus-playwright

Playwright enables reliable end-to-end testing for modern web apps
https://playwright.dev/
Apache License 2.0
6 stars 1 forks source link

opentest4j warning #27

Closed kucharzyk closed 4 months ago

kucharzyk commented 8 months ago

After adding quarks-playwright to my project I am getting the following warning in application logs

[WARNING] [io.quarkus.maven.MavenDevModeLauncher$Builder] org.opentest4j:opentest4j::jar classpath entry /Users/tomasz/.m2/repository/org/opentest4j/opentest4j/1.3.0/opentest4j-1.3.0.jar was overriden with /Users/tomasz/.m2/repository/org/opentest4j/opentest4j/1.2.0/opentest4j-1.2.0.jar

It looks like opentest4j come from quarkus-playwright

[INFO] \- io.quarkiverse.playwright:quarkus-playwright:jar:0.0.1:test
[INFO]    +- com.microsoft.playwright:playwright:jar:1.37.0:test
[INFO]    |  +- org.opentest4j:opentest4j:jar:1.2.0:test
[INFO]    |  \- com.microsoft.playwright:driver:jar:1.37.0:test
[INFO]    \- com.microsoft.playwright:driver-bundle:jar:1.37.0:test

I am using latest version of Quarkus: 3.6.6

ia3andy commented 8 months ago

I've checked both quarkus-junit5 and playwright are using opentest4j 1.2.0, do you have another dependency in your tree with opentest4j 1.3.0?

@aloubyansky since quarkus-playwright depends on both playwright and quarkus-junit5 maybe it would make sense to exclude opentest4j from one of them?

 <dependency>
      <groupId>com.microsoft.playwright</groupId>
      <artifactId>playwright</artifactId>
      <version>${playright.version}</version>
      <exclusions>
        <exclusion>
          <groupId>org.opentest4j</groupId>
          <artifactId>opentest4j</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
kucharzyk commented 8 months ago

@ia3andy @aloubyansky I think it should be excluded as it conflicts with junit which is using newer version

[INFO] --- dependency:3.6.1:tree (default-cli) @ fms ---
[INFO] com.shardis.fms:fms:jar:1.0.0-SNAPSHOT
[INFO] +- io.quarkus:quarkus-junit5:jar:3.6.7:test
[INFO] |  \- org.junit.jupiter:junit-jupiter:jar:5.10.1:test (version managed from 5.10.1)
[INFO] |     +- org.junit.jupiter:junit-jupiter-api:jar:5.10.1:test (version managed from 5.10.1)
[INFO] |     |  \- (org.opentest4j:opentest4j:jar:1.3.0:test - omitted for conflict with 1.2.0)
[INFO] |     \- org.junit.jupiter:junit-jupiter-engine:jar:5.10.1:test (version managed from 5.10.1)
[INFO] |        \- org.junit.platform:junit-platform-engine:jar:1.10.1:test (version managed from 1.10.1)
[INFO] |           \- (org.opentest4j:opentest4j:jar:1.3.0:test - omitted for conflict with 1.2.0)
[INFO] \- io.quarkiverse.playwright:quarkus-playwright:jar:0.0.1:test
[INFO]    \- com.microsoft.playwright:playwright:jar:1.37.0:test
[INFO]       \- org.opentest4j:opentest4j:jar:1.2.0:test
[INFO] ------------------------------------------------------------------------

You can check it using this command

./mvnw dependency:tree -Dverbose=true -Dincludes=org.opentest4j