search

quarkiverse / quarkus-poi

Apache POI is an API to access Microsoft Office files. This extension provides integration with Apache POI
https://poi.apache.org/
Apache License 2.0
12 stars 3 forks source link

Include missing XMLBeans schemas in the native image #60

Closed knuspertante closed 1 year ago

knuspertante commented 1 year ago
melloware commented 1 year ago

Build is running now.

gastaldi commented 1 year ago

Can you format the sources using mvn clean process-sources?

Formatted changes pushed

gastaldi commented 1 year ago

@all-contributors add @knuspertante for bug and test

allcontributors[bot] commented 1 year ago

@gastaldi

I've put up a pull request to add @knuspertante! :tada:

gastaldi commented 1 year ago

@knuspertante I pushed the fix to your branch and renamed the PR (hope you don't mind) 😄 Can you give it a shot?

Also I'd appreciate the feedback from the @quarkiverse/quarkiverse-poi team 😉

knuspertante commented 1 year ago

@gastaldi thanks! LGTM and works very well!

That's funny, because the missing resource was also my first thought but after i monitored the jvm mode with the tracing agent, this entry was not included in the resource-config.json. That's why I thought it can't be that and the xsb are already compiled as a class.

Thanks for adding me as a contributor, I appreciate that!

@gastaldi @melloware I think this could be merged or do I have to do something, like rename the test / file, clean up the commit history, ... ?

melloware commented 1 year ago

I squashed it for you!

gastaldi commented 1 year ago

@melloware fancy backporting this to 1.x and releasing both?

melloware commented 1 year ago

yep i will put it on my list today!