melloware
commented
1 year ago I will try that but that doesn't make any sense. Those classes are found fine and then you simply add JPA and they are not found seems impossible unless it's a Quarkus bug.
Closed gesker closed 1 year ago
melloware
commented
1 year ago I will try that but that doesn't make any sense. Those classes are found fine and then you simply add JPA and they are not found seems impossible unless it's a Quarkus bug.
melloware
commented
1 year ago Reported to Quarkus: https://github.com/quarkusio/quarkus/issues/32337
melloware
commented
1 year ago quarkus guys helped me. It was a Myfaces Issue: https://github.com/apache/myfaces/pull/559
I still get these but I htink I can fix that here in PrimeFaces Extension
Warning: Could not register org.primefaces.model.file.CommonsUploadedFile: allDeclaredConstructors for reflection. Reason: java.lang.NoClassDefFoundError: org/apache/commons/fileupload/FileItem.
Warning: Could not register org.primefaces.model.file.CommonsUploadedFile: allDeclaredFields for reflection. Reason: java.lang.NoClassDefFoundError: org/apache/commons/fileupload/FileItem.@all-contributors add @gesker for bugs
allcontributors[bot]
commented
1 year ago @melloware
I've put up a pull request to add @gesker! :tada:
gesker
commented
1 year ago Thanks again, @melloware.
When 3.12.3 hits maven I'll confirm. BTW, I'm still migrating getting ready for Quarkus 3 and I'm fine to package NON-native for a while. So, hair isn't on fire or anything like that.
You think there is a chance it will the upstream (quarks-myfaces) will arrive in time for 3.12.3 or will that take a little longer? Just asking as quarkus-myfaces is a dependency in quarkus-omnifaces, too.
melloware
commented
1 year ago I will ask on the MyFaces channel I have. I would really like a 4.0.1 Release.
melloware
commented
1 year ago OK @gesker I had to revert the MyFaces fix. These warnings we may have to live with because what MyFaces does is find all @Named or @Produces components and registers them for reflection.
It also does the _ClientProxy because if not I just built Quarkus Faces in Native mode and now things like PF AutoComplete can't find their complete method because of EL reflection.
<p:autoComplete id="acDelay" queryDelay="1000" value="#{autoCompleteView.txt3}"
completeMethod="#{autoCompleteView.completeText}" effect="blind" scrollHeight="250"/>So I had no choice but to put it back and live with these warnings unless we find a better way.
melloware
commented
1 year ago OK was able to reduce the warnings but not remove them entirely.
A baby step reproducer @melloware
Quarkus Faces as base for reproducer.
Added class xyz.lookatme.Meeseeks with a number of JPA/Hibernate Annotations to a reproducer .
Added to same reproducer using dependencies:
No other changes to Quarkus Faces.
'mvn clean compile' is all good. 'mvn clean compile package -Pnative' does complete but issues: