Short review - Githubissues

quarkiverse / quarkus-primefaces

Quarkus PrimeFaces Faces (JSF) Extension

https://github.com/primefaces/primefaces

Apache License 2.0

33 stars 3 forks source link

Closed tandraschko closed 1 year ago

tandraschko commented 1 year ago

in general everything looks good, thanks! I also like to finally switch from String class names to SomeClass.class.getName

Just some minor stuff:

´Primefaces´Processor.java; We should really name it ´PrimeFaces´ like everywhere else in the JSF world
ANNOTATED_CLASSES - why do we have it? isnt really used?

melloware commented 1 year ago

Fixed Primefaces to PrimeFaces in all files

Removed ANNOTATED CLASSES it was a cut and paste! Thanks!