quarkiverse / quarkus-reactive-messaging-nats-jetstream

Easily integrate to NATS.io JetStreams
https://docs.quarkiverse.io/quarkus-reactive-messaging-nats-jetstream/dev/index.html
Apache License 2.0
8 stars 5 forks source link

Dead docs link in superseded extension metadata #39

Closed holly-cummins closed 7 months ago

holly-cummins commented 7 months ago

This is a bit complicated, and I'm not sure what the optimum fix is.

It looks like two jetstream extensions have been published, one with the io.quarkiverse extension (https://quarkus.io/extensions/io.quarkiverse/quarkus-reactive-messsaging-nats-jetstream/) and one with a group id that include nats jetstream (https://quarkus.io/extensions/io.quarkiverse.reactivemessaging.nats-jetstream/quarkus-reactive-messsaging-nats-jetstream/).

The docs link in the older version of the extension is dead. It's only a little issue, but we try not to have dead links. I can see the following solutions:

WDYT, @kjeldpaw and @gastaldi?

gastaldi commented 7 months ago

I believe it was never the intention to use the io.quarkiverse group ID in that extension (The group ID was changed in subsequent releases: https://github.com/quarkusio/quarkus-extension-catalog/commit/c53afcef1b02e8affd7765515beb37dd9016a15e).

I'm +1 to sneakily delete it from the registry (FTR I do that using the REST API)

holly-cummins commented 7 months ago

Yes, I thought it looked like an accident, too. I agree that makes it more reasonable to do sneaky deletions. :)

gastaldi commented 7 months ago

Deleted from the registry. Closing this ticket now. Thanks for spotting it @holly-cummins!

kjeldpaw commented 7 months ago

It was an accident :( Ozan brought this to my attention quickly and we got it fixed

gastaldi commented 7 months ago

@holly-cummins on another topic, in https://quarkus.io/extensions/io.quarkiverse/quarkus-reactive-messsaging-nats-jetstream/ can we make the A newer version of this extension has been released with the group id io.quarkiverse.reactivemessaging.nats-jetstream message a link to the newer extension?

gastaldi commented 7 months ago

It was an accident :( Ozan brought this to my attention quickly and we got it fixed

This is something we could have detected in the pre-release workflow. I'll have a look on how to make it easier for everyone

holly-cummins commented 7 months ago

@holly-cummins on another topic, in https://quarkus.io/extensions/io.quarkiverse/quarkus-reactive-messsaging-nats-jetstream/ can we make the A newer version of this extension has been released with the group id io.quarkiverse.reactivemessaging.nats-jetstream message a link to the newer extension?

I was just noticing that today, too. The text at the bottom has the link, but it's natural to try and click on the first message, which is the top. I've raised https://github.com/quarkusio/extensions/issues/635.