search

quarkiverse / quarkus-roq

An extension to generate/publish static pages from your Quarkus web-app
https://pages.quarkiverse.io/quarkus-roq/
Apache License 2.0
14 stars 8 forks source link

Amend asciidoc related documentation #234

Open jtama opened 16 hours ago

jtama commented 16 hours ago

The documentation still explains Asciidoc support is coming, where it should it's already partially there.

We should also mention that support is limited for the moment. From my experiment, the support is only there for plain asciidoc :

Do you agree ?

ia3andy commented 16 hours ago

@jtama would you be our asciidoc owner? (meaning you take care of improving the asciidoc xp)

jtama commented 16 hours ago

I would like, but I don't know exactly what it would mean in terms of time investment. My first guess would be to move from yupiik:asciidoc-java. I guess I can give it a try and if that's too much withdraw at some point.

But I can start with a PR for the doc ;), that is MUCH cheaper.

ia3andy commented 15 hours ago

@jtama TBH, it's entirely up to you... this is a place to have fun not to work :)

Having a basic asciidoc support is already great and might cover most of the needs..

I am a YAGNI fan, so let's wait for people needing things to change...

For the owning part, I meant more if there are issues or queries, then you we would ping you.

It doesn't mean you have to do the fix or the feature, just you would own the process..

jtama commented 15 hours ago

Oh okay then, with pleasure.

For the asciidoc part, beeing an active user, one of my main habit is to split documentation, and the include issue a big one.

I guess I will do the documentation PR, and then an file an issue for the rest ;)