search

quarkiverse / quarkus-vault

Quarkus HashiCorp Vault extension
Apache License 2.0
19 stars 26 forks source link

Add PEM_BUNDLE to pki DataFormat enum #192

Closed aaronz-vipaso closed 3 weeks ago

aaronz-vipaso commented 11 months ago

I would like to sign a certificate with the PKI engine and use the pem_bundle format. Currently, the DataFormat enum only contains der and pem.

Is it only required to add another entry in io.quarkus.vault.pki.DataFormat to solve this?

kdubb commented 11 months ago

@aaronz-vipaso That would be 1 thing that needs to happen. Additionally the CertificateData class would need to be updated to be able to handle that format and the API requests would need to be able to select that format (passed in from the model class GenerateCertificateOptions) and then be able to process the resultant data into a CertificateData.

kdubb commented 3 weeks ago

@aaronz-vipaso This is now doable with the new client introduced in 4.+