search

quarkiverse / quarkus-vault

Quarkus HashiCorp Vault extension
Apache License 2.0
19 stars 26 forks source link

Revert to using HTTP when connecting to dev services containers #198

Closed kdubb closed 11 months ago

kdubb commented 11 months ago

This fixes dev services by using the correct scheme, HTTP, when connecting to automatically started dev services containers.

@vsevel I'm thinking we revert this to HTTP instead of passing the new -dev-tls flag and using HTTPS. My reasoning is just, as we've discussed previously, security products are generally updated slowly and the new flag requires Vault 1.12+.

We could selectively enable TLS but we'd need to be figuring it out prior to container startup based on the image tag. It can be done it's just work I don't have time for and we need to get this back in working order.

Also, we really need to add a unit test that actually uses a proper "dev services" container. Unfortunately I'm swamped at the moment.

kdubb commented 11 months ago

/cc @bmscomp

kdubb commented 11 months ago

If you're not up-to-date on what this is related to see #178 where I originally commented on the closed PR

bmscomp commented 11 months ago

@kdubb Thanks for the PR I was working right now on a same fix

kdubb commented 11 months ago

@bmscomp Can you add a test that actually uses a dev services container so we don't run into this problem again?

kdubb commented 11 months ago

We must merge this ASAP to ensure dev services is restored for before Quarkus 3.6.0 is released.

@gsmet If I make a 3.3.1 version of the extension is that something that can be back ported into 3.5.3? Currently dev services is broken for the 3.5 series.

vsevel commented 11 months ago

I was planning a release anyway for 3.6.0 (quarkus vault 3.4 then) we can add a 3.3.1 for quarkus 3.5.

kdubb commented 11 months ago

@vsevel Should we cut a CR2 just to ensure a "release" works (since we don't yet have a test).

vsevel commented 11 months ago

see https://github.com/quarkiverse/quarkus-vault/pull/199