search

quarkiverse / quarkus-vault

Quarkus HashiCorp Vault extension
Apache License 2.0
19 stars 24 forks source link

JDK 17 #237

Closed vsevel closed 6 months ago

kdubb commented 6 months ago

@vsevel Isn't this already done in #238?

vsevel commented 6 months ago

@vsevel Isn't this already done in #238?

yes @kdubb this PR was originally intending to move to CR1 then 3.8.0, plus JDK 17 the only thing to do is JDK 17 can you validate? then I will do the release, and update the platform

kdubb commented 6 months ago

👍 All good for me

kdubb commented 6 months ago

@vsevel I think we can remove the compiler source/target versions altogether because they are set in the base Quarkivers POM; I noticed they are absent in my other Quarkiverse projects.

@gastaldi Can you confirm this?

gastaldi commented 6 months ago

@kdubb yes, if your project uses the latest quarkiverse-parent

kdubb commented 6 months ago

I'll do this #215 which was already using JDK 17 for the generator module (because Quarkus was already requiring 17)