search

quarkiverse / quarkus-wiremock

Quarkus extension for launching an in-process Wiremock server
https://wiremock.org/
Apache License 2.0
16 stars 10 forks source link

feat: enable global response templating #51

Closed wjglerum closed 11 months ago

wjglerum commented 11 months ago

See https://wiremock.org/2.x/docs/response-templating/

wjglerum commented 11 months ago

Thank your very much for your contribution. Your work is very appreciated. Unfortunately, the implementation is based on the WireMock 2 approach, but we'd like to traget WireMock 3. Maybe we can merge the most parts of this PR into X.0, but I would ask for a rework when targeting main. Thank you so much.

Edit: Ah my fault, you're targeting 0.x :-) Then I have just some minor comments.

yeah was going to make another one for Quarkus 3 + WireMock 3 :) thanks for the review!

wjglerum commented 11 months ago

@chberger addressed your concerns, I'll continue this work for WireMock 3 with a PR to the main branch next.

chberger commented 11 months ago

@all-contributors add @wjglerum for doc

allcontributors[bot] commented 11 months ago

@chberger

I've put up a pull request to add @wjglerum! :tada: