Bug: WireMock config Live reload glitches on Windows

quarkiverse / quarkus-wiremock

Quarkus extension for launching an in-process Wiremock server

https://wiremock.org/

Apache License 2.0

16 stars 10 forks source link

Bug: WireMock config Live reload glitches on Windows #69

Closed oleg-nenashev closed 7 months ago

oleg-nenashev commented 10 months ago

The WireMock config live reload starts working only after the first class reload. It looks like the extension properly registers the reload monitors only after the first Code reload. Or maybe it is a Quarkus glitch.

Reproduction steps

Run https://github.com/wiremock/wiremock-quarkus-devservice-demo on Windows /Powershell
Run quarkus dev
Access REST API for Hacker News
Edit the configuration resource
Reload the page

Error: The configuration does not change until the first classes reload

Versions

Quarkus Version and BOM: 3.5.3
WireMock Extension: 1.0.0

chberger commented 10 months ago

Hi @oleg-nenashev, thanks for reporting this. To be honest, it works as designed: WireMock config files aren't watched yet. That's why your config changes are just recognised when the live reload has been triggered by something else. However, I agree it would make totally sense to watch for such config changes as well. I'll provide a PR as soon as I have some time.

Does WireMock only support JSON config files or also YAML files? I've just checked the docu quickly, but couldn't find anything else than JSON. I'm just asking because I would need to know what type of files need to be watched.

oleg-nenashev commented 10 months ago

Hi. YAML support is coming soon. There is a staged PR that we hope to merge soon https://github.com/wiremock/wiremock/issues/2411

chberger commented 8 months ago

Hi @oleg-nenashev, I've implemented the requested feature with https://github.com/quarkiverse/quarkus-wiremock/pull/85. Would be nice if you could review it! Thanks!