WireMock config changes are taken into account for live-reload (dev mode only)

quarkiverse / quarkus-wiremock

Quarkus extension for launching an in-process Wiremock server

https://wiremock.org/

Apache License 2.0

15 stars 8 forks source link

Closed chberger closed 5 months ago

chberger commented 5 months ago

This PR makes the Live Reload feature of Quarkus Dev Mode aware of WireMock config changes. However, the implementation has some limitations:

The file modification gets only recognized after a http request. --> Fits naturally to the WireMock usage model
A manual app restart is required when adding a new config file at runtime

oleg-nenashev commented 5 months ago

Sorry for delay, new job onboarding :(

chberger commented 5 months ago

Sorry for delay, new job onboarding :(

Don't worry, I am very grateful that you are doing a review at all. 😄

chberger commented 5 months ago

@oleg-nenashev: Any further feedback? Otherwise I would release the feature soon.

oleg-nenashev commented 5 months ago

Hi. I didn't have a chance to review it yet, was snowed under the onboarding stuff at Gradle. I do not see anything wrong so I would just ship it