search

quarkly / atomize

library for creating atomic react components
https://atomize.quarkly.io
MIT License
66 stars 6 forks source link

Add fill property to dict #13

Closed Maks1mS closed 4 years ago

Maks1mS commented 4 years ago

12

Maks1mS commented 4 years ago

Also, alias of "display" ("d") conflicts with property "d" of SVG. Maybe change "d" to "dp"? изображение

eddort commented 4 years ago

Thank you for your PR! We are researching the possibility of replacing the alias and will let you know the result later. Thank you for your participation!

Maks1mS commented 4 years ago
List of possible conflicts: SVG Attributes description Conflict
d define a path display
z location along the z-axis for a light source z-index
r circle radius right

If I find more conflicts I will update the table

eddort commented 4 years ago

Hey, we looked into the problem and found the following solution. Add the feature to disable the alias system when creating a component using atomize - useAliaes: boolean (default true) const MyComp = atomize.svg({effects: {hover: '.hover'}, useAliaes: false}) https://github.com/quarkly/atomize/pull/14

eddort commented 4 years ago

@Mobydack