I started the migration to Typescript because you have written this in your TODO in README. I changed the main files for working with autocomplete and static types for props.
Changes
added rollup for optimizing bundle with babel and typescript definitions;
changed rm -rf to rimraf for working from Windows;
removed some unused dependencies which I handle with depcheck;
Also can be removed:
Current known flaws/bugs:
can't handle useAliases: false;
can't throw an error, when incorrect props set, like in styled-components;
I set type for keys of dict object to keyof CSS.PropertiesHyphen from csstype, but some CSS properties were not found (some of this I can't find in MDN!).
Also I changed mistype 'outline-width|thin|medium|thick' to 'outline-width'.
For generating valid types of dict(full name and aliases) I create a script, which you can run
$ npm run dict
I don’t know if it’s the best way, but I haven’t come up with another solution.
TODO
I am describing this task for all contributors because I do not know if I will do it.
[ ] Fix all bugs and flaws
[x] can't handle useAliases: false
[ ] can't throw an error, when incorrect props set, like in styled-components;
[x] Change type from string to string literals.
[ ] Change other files to typescript
[ ] Remove all 'any'
[ ] Update tests for typescript
P.S.
I think that this pull request need be merged into 'feat/typescript' for additional changes instead 'master', but I can't do this, because 'feat/typescript' doesn't exist.
Hi, thank you for your contribution.
Today we're working on a new big patch at quarkly.io.
In a couple of days, I'm gonna start working on atomize and we're will merge this PR to the master.
Introduction
I started the migration to Typescript because you have written this in your TODO in README. I changed the main files for working with autocomplete and static types for props.
Changes
rm -rf
to rimraf for working from Windows;Current known flaws/bugs:
useAliases: false
;to
Some details
I set type for keys of dict object to
keyof CSS.PropertiesHyphen
from csstype, but some CSS properties were not found (some of this I can't find in MDN!). Also I changed mistype 'outline-width|thin|medium|thick' to 'outline-width'.For generating valid types of dict(full name and aliases) I create a script, which you can runI don’t know if it’s the best way, but I haven’t come up with another solution.
TODO
I am describing this task for all contributors because I do not know if I will do it.
useAliases: false
P.S.
I think that this pull request need be merged into 'feat/typescript' for additional changes instead 'master', but I can't do this, because 'feat/typescript' doesn't exist.