quarkly / atomize

library for creating atomic react components
https://atomize.quarkly.io
MIT License
66 stars 6 forks source link

feat: Start migration to typescript #18

Open Maks1mS opened 4 years ago

Maks1mS commented 4 years ago

Introduction

I started the migration to Typescript because you have written this in your TODO in README. I changed the main files for working with autocomplete and static types for props. изображение

Changes

Current known flaws/bugs:

Some details

I set type for keys of dict object to keyof CSS.PropertiesHyphen from csstype, but some CSS properties were not found (some of this I can't find in MDN!). Also I changed mistype 'outline-width|thin|medium|thick' to 'outline-width'. For generating valid types of dict(full name and aliases) I create a script, which you can run

$ npm run dict

I don’t know if it’s the best way, but I haven’t come up with another solution.

TODO

I am describing this task for all contributors because I do not know if I will do it.

P.S.

I think that this pull request need be merged into 'feat/typescript' for additional changes instead 'master', but I can't do this, because 'feat/typescript' doesn't exist.

eddort commented 4 years ago

Hi, thank you for your contribution. Today we're working on a new big patch at quarkly.io. In a couple of days, I'm gonna start working on atomize and we're will merge this PR to the master.