search

quarks-css / quarks

A CSS-in-JS library for applying styles to React components via props
MIT License
3 stars 1 forks source link

Export standard Quarks #11

Open jpwallace22 opened 1 year ago

jpwallace22 commented 1 year ago

Describe the solution you'd like Expose pre-created Quarks for the main HTML elements (and include Flex and Grid)

Describe alternatives you've considered We could not expose them and make it so everything is just "do as you please"

Additional context Adding the predefined elements adds a bit of code to the dependency, but it shoudnt be enough to cause any issues.

dslovinsky commented 1 year ago

(and include Flex and Grid)

I actually think we should move away from this. Having dedicated quarks for different display types made sense when we were gating certain display-specific properties by quark, but in the current implementation all CSS properties are available on all quarks. With that in mind I think a more intuitive dev experience is to simply have one quark per element (ex. Div, P, etc.)

jpwallace22 commented 1 year ago

Due to the size of this, I think it's best we table it for now. If we find down the line that this is a useful feature, it can be added. But for now, I think the function introduced in #10 to allow a single quark call to make an array of elements is a good stand-in. I am going to leave this issue open and add a consideration tag. Will revisit.

dslovinsky commented 1 year ago

Agreed. Removed it from the project board