quarks-css / quarks

A CSS-in-JS library for applying styles to React components via props
MIT License
3 stars 1 forks source link

feat: `quarks` types & `createStylesFromProps` #5

Closed dslovinsky closed 1 year ago

dslovinsky commented 1 year ago

Closes #6

Changes

Other notes (things to check, explanation of implementation, etc.)

Update: The above has been addressed. Intellisense works normally now and tsup is able to output all types without error.

dslovinsky commented 1 year ago

Were you able to build this on local? Its tossing an error for me.

No, that's what the second bullet point in my Notes section is about. It works up to a certain size, but adding media and pseudo types added too much. I think switching from tsup to a bundler that maintains original type definitions based on mapped types (rather than trying to "hard-code" the full type) should solve the issue.

jpwallace22 commented 1 year ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: