Closed dslovinsky closed 1 year ago
Were you able to build this on local? Its tossing an error for me.
No, that's what the second bullet point in my Notes section is about. It works up to a certain size, but adding media and pseudo types added too much. I think switching from tsup to a bundler that maintains original type definitions based on mapped types (rather than trying to "hard-code" the full type) should solve the issue.
:tada: This PR is included in version 1.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Closes #6
Changes
QuarkStyles
to manage prop types in quarksPropsType
to manage type ofprops
args increateStylesFromProps
~setupQuarks
name tosetup
createStylesFromProps
to reduce Intellisense lagOther notes (things to check, explanation of implementation, etc.)
PropsType
, seems to be a bit too much for Intellisense to handle. It dramatically slows down type evaluation (does not affect apps using Quarks sincePropsType
is not exported). This is a good starting point but I think we need to consider simplifying. Slowing down the dev experience just for typing of values in an internal function is likely not worth it.StyleProps
was literally too large fortsup
to compile. I think we should use a different compiler because the waytsup
handles these is pretty dumb - rather than capturing a type in a definition and reusing it in a nested type, it writes out all possible properties leading to thousands of lines. As a result the types don't even seem to work.Update: The above has been addressed. Intellisense works normally now and tsup is able to output all types without error.