search

quarkslab / irma

IRMA is an asynchronous & customizable analysis system for suspicious files.
https://irma.quarkslab.com
Apache License 2.0
268 stars 55 forks source link

Fix Ansible variables for Eset File Security #65

Closed windgmbh closed 4 years ago

windgmbh commented 4 years ago

Some Ansible variables for "Eset File Security" where not used consistently. Therefore the provisioning was caused to fail.

ch0k0bn commented 4 years ago

First of all, thanks for your MR. Would it be possible to squash the 2 first commits and have the commit msg follow this commit msg format, because whe are using semantic release and changelog is built from commit message.

e.g: commit msg could be

fix(ansible): eset_file_security variables

for the kaspersky part, maybe another MR is better as it requires also probe module modification (that we already have in version 3) and could be discussed separately

windgmbh commented 4 years ago

Thanks for your answer. I will work on a nicer commit format at the beginning of next week. Concerning the Kaspersky changes I forgot to add the already working code for the Kaspersky probe module and will include those in the revised commits.