quarkslab / quokka

Quokka: A Fast and Accurate Binary Exporter
https://quarkslab.github.io/quokka/
Apache License 2.0
166 stars 11 forks source link

Dependencies too restrictives #18

Closed RobinDavid closed 11 months ago

RobinDavid commented 1 year ago

Quokka setup.py defines the following dependencies:

As capstone 5.0.0 is now released, it makes quokka incompatible with latest capstone version. I am wondering why we purposely restricted the maximum version. I suggest:

DarkaMaul commented 1 year ago

I am wondering why we purposely restricted the maximum version. I suggest:

The idea here is to make sure we don't introduce a breaking change in Quokka before it has been tested. If the dependency follows semantic versioning best practices, it guarantees that incompatible API change only occur during major version update ( exactly those who are prevented by this requirement).

removing pypcode as a mandatory dependency

I completely agree here :)