quarkus-for-spring-developers / examples

Example code for the Quarkus for Spring Developers eBook
https://red.ht/quarkus-spring-devs
Apache License 2.0
46 stars 17 forks source link

Chapter 6: quarkus-rest-config: application.properties Questions #74

Closed edeandrea closed 3 years ago

edeandrea commented 3 years ago

Sub-issue of quarkus-for-spring-developers/project-management#31

In src/main/resources/application.properties is

quarkus.kubernetes.ingress.host=chapter-6-quarkus-rest-config.127.0.0.1.nip.io
quarkus.kubernetes.ports.http.host-port=8080
quarkus.kubernetes.ports.http.container-port=8080

necessary?

edeandrea commented 3 years ago

@cmoulliard I don't know the answer to this. If these are required then we can simply close out this ticket.

cmoulliard commented 3 years ago
quarkus.kubernetes.ingress.host=chapter-6-quarkus-rest-config.127.0.0.1.nip.io

This property is necessary to configure properly the ingress controller in order to access the service using the host address

cmoulliard commented 3 years ago
quarkus.kubernetes.ports.http.host-port=8080
quarkus.kubernetes.ports.http.container-port=8080

No. I will remove them ;-)

cmoulliard commented 3 years ago

Issues reported fixed. Can you check https://github.com/quarkus-for-spring-developers/examples/blob/main/chapter-6/chapter-6-quarkus-rest-config/README.md and close it when done please ? @edeandrea