search

quarkus-for-spring-developers / examples

Example code for the Quarkus for Spring Developers eBook
https://red.ht/quarkus-spring-devs
Apache License 2.0
46 stars 17 forks source link

Move SCCS location to new repo #96

Closed edeandrea closed 3 years ago

edeandrea commented 3 years ago

Moving SCCS stuff to new repo.

@cmoulliard can you review? The repo is public for now & I was able to run 

docker run -it -p 8888:8888 \
      -e SPRING_CLOUD_CONFIG_SERVER_GIT_URI=https://github.com/quarkus-for-spring-developers/sccs-config-repo \
      -e SPRING_CLOUD_CONFIG_SERVER_GIT_DEFAULT-LABEL=main \
      -e SPRING_CLOUD_CONFIG_SERVER_GIT_SEARCHPATHS={application} \
      hyness/spring-cloud-config-server

And then running http :8888/greeting-application-prod.properties returns

HTTP/1.1 200 
Connection: keep-alive
Content-Length: 59
Content-Type: text/plain
Date: Fri, 25 Jun 2021 18:23:35 GMT
Keep-Alive: timeout=60

greeting.message: Hello cloud config
greeting.name: quarkus

Fixes #84

cmoulliard commented 3 years ago

Great PR. LGTM. Can be merged

edeandrea commented 3 years ago

@cmoulliard is there anything in the chapter text that needs to be updated based on this?

cmoulliard commented 3 years ago

I dont think so as the G doc dont include the reference of the github repository maintaining the code of the configurations for the SCC