search

quarkus-qe / quarkus-test-framework

Write your test once and run it everywhere!
Apache License 2.0
14 stars 26 forks source link

Build time properties incorectly handles .withProperty #1149

Closed mocenas closed 1 month ago

mocenas commented 1 month ago

After #1128 Build time properties are not always handled correctly. If a property is set with RestService().withProperty it is not detected as a buildTime property and causes some tests to fail.

e.g. https://github.com/quarkus-qe/quarkus-test-suite/blob/main/http/graphql/src/test/java/io/quarkus/ts/http/graphql/GraphQLDisabledGetIT.java#L25 Fails with: 

[app] 09:29:14,822 Build time property cannot be changed at runtime:
[app]  - smallrye.graphql.allowGet is set to 'false' but it is build time fixed to 'true'. Did you change the property smallrye.graphql.allowGet after building the application?

also https://github.com/quarkus-qe/quarkus-test-suite/blob/main/http/http-advanced/src/test/java/io/quarkus/ts/http/advanced/DomainSocketIT.java#L36 fails with:

WARN: Build time property cannot be changed at runtime:
INFO  [app]  - quarkus.oidc.enabled is set to 'false' but it is build time fixed to 'true'. Did you change the property quarkus.oidc.enabled after building the application?

From these error messages, quarkus considers these properties buildTime ones, but we do not.