search

quarkus-qe / quarkus-test-framework

Write your test once and run it everywhere!
Apache License 2.0
14 stars 26 forks source link

Automatically publish release notes #1159

Closed michalvavrik closed 1 month ago

michalvavrik commented 1 month ago

Summary

related to https://github.com/quarkus-qe/quarkus-test-framework/issues/414

I used GH CLI to test deletion of API tag (so that we can identify the latest draft), but I didn't try release itself for I don't want to release things. It seems clear enough from docs reference https://cli.github.com/manual/gh_release_edit. I'll try to do actual release and find a way to debug it locally if it fails.

Please check the relevant options

Checklist:

michalvavrik commented 1 month ago

In general, is this something we want to do? We should automate the annoying part of the releases (like tagging and pushing to sonatype), but in general, I think this change is going to move people even further from what happens in the releases they produce.

it was your idea...

The other thing is that even without release drafter, github produces release notes draft between selected tags already, but I think that people not knowing what happened in their releases and just pushing the button will make things not better

I don't see how having to remember to go to release notes, click on tag, change title and click on publish is anything but monkey business. I don't read it.

michalvavrik commented 1 month ago

okay, if by https://github.com/quarkus-qe/quarkus-test-framework/issues/414 you mean just having it work for non-main branch stream, it's fine with me

mjurc commented 1 month ago

We can still have it in btw if people think it's useful, I was just voicing my concerns

michalvavrik commented 1 month ago

We can still have it in btw if people think it's useful, I was just voicing my concerns

I don't mind either way. I was angry with myself spending time on it because I misread #414. Honestly I don't care. Let's forget about it.