quarkus-qe / quarkus-test-framework

Write your test once and run it everywhere!
Apache License 2.0
14 stars 26 forks source link

Release Beta8 of the framework #1177

Closed fedinskiy closed 1 week ago

fedinskiy commented 2 weeks ago

Summary

The title says it all

Please check the relevant options

Checklist:

michalvavrik commented 1 week ago

@fedinskiy release flow is failing https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/9681515160/job/26712468004 please have a look, I'm busy atm

michalvavrik commented 1 week ago

looks like gpg_private_key is missing as we do use v6 of that GH action and I guess it has been updated in minor

mjurc commented 1 week ago

Github actions can only see secrets from the trunk repository. Forks PRs don't have access to secrets.

The release PRs need to happen from this repository.

michalvavrik commented 1 week ago

arg! thanks @mjurc I didn't check

mjurc commented 1 week ago

np, it's easy to miss. Almost makes me think we should have a check for the origin too for when .github/project.yml is changed.

michalvavrik commented 1 week ago

Almost makes me think we should have a check for the origin too for when .github/project.yml is changed.

+1

mjurc commented 1 week ago

https://github.com/quarkus-qe/quarkus-test-framework/issues/1179