quarkus-qe / quarkus-test-framework

Write your test once and run it everywhere!
Apache License 2.0
14 stars 26 forks source link

Add check for same repo PR origin for releases #1182

Closed mocenas closed 1 week ago

mocenas commented 1 week ago

Summary

closes: #1179

Release PRs can only be executed if source branch is in same repo, because of GH secrets. This adds a check to verify that it is so.

Please check the relevant options

Checklist:

mocenas commented 1 week ago

I've tested this on my own forks: Passed example: https://github.com/mocenas/quarkus-test-framework/pull/21 Failed example: https://github.com/mocenas/quarkus-test-framework/pull/22

rsvoboda commented 1 week ago

+1 to sync naming

michalvavrik commented 1 week ago

cc @fedinskiy CI failure (wonder if that is flakiness, it seems like daily is ok)

fedinskiy commented 1 week ago

@michalvavrik it is flakiness, I saw it during CI for the release, it was cured by rerun. Created https://github.com/quarkus-qe/quarkus-test-framework/issues/1186, will take a look.

michalvavrik commented 1 week ago

+1 to sync naming

I'd not say it's synced. but changed. @rsvoboda merge if you like.

rsvoboda commented 1 week ago

I would like to see this

Release check / check-release-version (pull_request)
Release check / check-source-repo-is-not-a-fork (pull_request)
michalvavrik commented 1 week ago

I would like to see this

TBH me too, but I didn't want to be annoying. It looks better.

mocenas commented 1 week ago

I renamed also the version release check, to be consistent.