Closed gtroitsk closed 2 months ago
@gtroitsk It's look good to me! Just would be better also checking if the file is created with that suffix?
@gtroitsk It's look good to me! Just would be better also checking if the file is created with that suffix?
Let's go further, let's check content as it adds better coverage while this is very much like unit test. IMHO we don't want to test isolated bugs if we can have something similar to what users do. And if they enable logging to file, they are likely to desire there is a content.
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'
@gtroitsk it looks good, I still think you could refactor it bit, but please consider it rather unimportant.
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'
Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'
The flaky test is related to Kafka.
Summary
Verifies issue https://github.com/quarkusio/quarkus/issues/40016
Please select the relevant options.
run tests
phrase in comment)Checklist: