quarkus-qe / quarkus-test-suite

16 stars 35 forks source link

Verify log file rotation for periods longer than day #1946

Closed gtroitsk closed 2 months ago

gtroitsk commented 2 months ago

Summary

Verifies issue https://github.com/quarkusio/quarkus/issues/40016

Please select the relevant options.

Checklist:

jedla97 commented 2 months ago

@gtroitsk It's look good to me! Just would be better also checking if the file is created with that suffix?

michalvavrik commented 2 months ago

@gtroitsk It's look good to me! Just would be better also checking if the file is created with that suffix?

Let's go further, let's check content as it adds better coverage while this is very much like unit test. IMHO we don't want to test isolated bugs if we can have something similar to what users do. And if they enable logging to file, they are likely to desire there is a content.

github-actions[bot] commented 2 months ago

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

michalvavrik commented 2 months ago

@gtroitsk it looks good, I still think you could refactor it bit, but please consider it rather unimportant.

github-actions[bot] commented 2 months ago

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

github-actions[bot] commented 2 months ago

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

github-actions[bot] commented 2 months ago

Following jobs contain at least one flaky test: 'PR - Linux - JVM build - Latest Version'

michalvavrik commented 2 months ago

The flaky test is related to Kafka.