Add version suffix to docker images

mocenas commented 1 month ago

Summary

Adding ":latest" suffix to all docker images, that didn't have version.

Our test framework expects the images to have version. Otherwise it will fail.

On some places, tests are also working with image version so it makes sense to have them.

This is also causing failures in aarch64 tests.

Please select the relevant options.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] Dependency update
[ ] Refactoring
[ ] Backport
[ ] New scenario (non-breaking change which adds functionality)
[ ] This change requires a documentation update
[X] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Methods and classes used in PR scenarios are meaningful
[X] Commits are well encapsulated and follow the best practices

mocenas commented 1 month ago

run tests

mocenas commented 1 month ago

I've changed kafka image properties to it's original state, as it is required somewhere in the TS to have it separate properties for image and version.

Other failures in both CI and jenkins seems unrelated.

mocenas commented 1 month ago

run tests

github-actions[bot] commented 1 month ago

Following jobs contain at least one flaky test:

PR - Linux - JVM build - Latest Version

Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11456025272?pr=2113

Flaky tests:

io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection

Failure message: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__ ____ __ _____ ___ __ ____ ______ , --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ , -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \ , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/ , 09:33:59,339 SRMSG18229: Configured topics for channel 'slow': [slow], 09:33:59,355 SRMSG18214: Key deserializer omitted, using String as default, 09:33:59,356 SRMSG18234: Auto-commit disabled for channel slow, 09:33:59,539 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 09:33:59,540 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 09:33:59,540 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 09:33:59,573 SRMSG18248: Key serializer omitted, using String as default, 09:33:59,607 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32826', is configured to write records to 'slow', 09:33:59,656 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32826', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 09:33:59,657 No Topology producer; Kafka Streams will not be started, 09:33:59,763 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.407s. Listening on: http://0.0.0.0:1104, 09:33:59,764 Profile prod activated. , 09:33:59,764 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 09:33:59,883 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 09:34:03,369 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@7ceb3da9 from channel 'slow-topic' to Kafka topic 'slow', 09:34:03,444 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@7ceb3da9 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
Failed in jobs:
- PR - Linux - JVM build - Latest Version
  
  Failure stacktrace

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 09:33:59,339 SRMSG18229: Configured topics for channel 'slow': [slow], 09:33:59,355 SRMSG18214: Key deserializer omitted, using String as default, 09:33:59,356 SRMSG18234: Auto-commit disabled for channel slow, 09:33:59,539 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 09:33:59,540 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 09:33:59,540 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 09:33:59,573 SRMSG18248: Key serializer omitted, using String as default, 09:33:59,607 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32826', is configured to write records to 'slow', 09:33:59,656 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32826', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 09:33:59,657 No Topology producer; Kafka Streams will not be started, 09:33:59,763 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.407s. Listening on: http://0.0.0.0:1104, 09:33:59,764 Profile prod activated. , 09:33:59,764 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 09:33:59,883 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 09:34:03,369 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@7ceb3da9 from channel 'slow-topic' to Kafka topic 'slow', 09:34:03,444 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@7ceb3da9 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
    at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
    at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
    at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
    at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
    at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
    at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:134)
    at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:124)
    at io.quarkus.test.utils.LogsVerifier.assertContains(LogsVerifier.java:28)
    at io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection(KafkaGratefulShutdownIT.java:71)
    at java.base/java.lang.reflect.Method.invoke(Method.java:569)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.opentest4j.AssertionFailedError: Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 09:33:59,339 SRMSG18229: Configured topics for channel 'slow': [slow], 09:33:59,355 SRMSG18214: Key deserializer omitted, using String as default, 09:33:59,356 SRMSG18234: Auto-commit disabled for channel slow, 09:33:59,539 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 09:33:59,540 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 09:33:59,540 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 09:33:59,573 SRMSG18248: Key serializer omitted, using String as default, 09:33:59,607 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32826', is configured to write records to 'slow', 09:33:59,656 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32826', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 09:33:59,657 No Topology producer; Kafka Streams will not be started, 09:33:59,763 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.407s. Listening on: http://0.0.0.0:1104, 09:33:59,764 Profile prod activated. , 09:33:59,764 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 09:33:59,883 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 09:34:03,369 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@7ceb3da9 from channel 'slow-topic' to Kafka topic 'slow', 09:34:03,444 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@7ceb3da9 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false>
    at io.quarkus.test.utils.LogsVerifier.lambda$assertContains$0(LogsVerifier.java:30)
    at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
    at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
    at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
    at java.base/java.lang.Thread.run(Thread.java:840)

mocenas commented 1 month ago

run tests

mocenas commented 1 month ago

Only failure in last OCP tests was OpenShiftPostgreSqlReactiveSbIT which is unrelated. In fails or success randomly even in current main.

mocenas commented 1 month ago

Can you look at this @michalvavrik ?

michalvavrik commented 1 month ago

Can you look at this @michalvavrik ?

you mean OpenShiftPostgreSqlReactiveSbIT or to review?

michalvavrik commented 1 month ago

Regarding OpenShiftPostgreSqlReactiveSbIT, I understand the issue and I'll try to fix it.

mocenas commented 1 month ago

Can you look at this @michalvavrik ?

you mean OpenShiftPostgreSqlReactiveSbIT or to review?

I meant to review the PR :-)

quarkus-qe / quarkus-test-suite

Add version suffix to docker images #2113

Summary

Checklist: