quarkus-qe / quarkus-test-suite

16 stars 34 forks source link

Disable tests that have no IBM ppc64le or s390x supporting images. #2123

Closed redmark-redhat closed 1 month ago

redmark-redhat commented 1 month ago

Disable tests that have no IBM ppc64le or s390x supporting images. Also, fix some tests to use images that do support ppc64le or s390x.

Also, see PR https://github.com/quarkus-qe/quarkus-test-suite/pull/2116

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please select the relevant options.

Checklist:

redmark-redhat commented 1 month ago

@michalvavrik Correct we should not test baremetal.

If you examine the test run here (https://main-jenkins-csb-pz.apps.ocp-c1.prod.psi.redhat.com/job/manual/job/rhr/job/Cloud-Native-Runtimes/job/Quarkus/job/rhbq-3.15.x-jdk-17-21/SCENARIO=databases-modules,label=OpenstackNode-valen2/62/) we don't have '-Dtest=!OpenShiftTodoDemoIT' set and we still see Oracle and MSSQL test(s) that would be executed. Here I have the disable logic and it skips them.

Is there a better way to skip/exclude these test(s)?

image image image image

michalvavrik commented 1 month ago

I'll put it this way @redmark-redhat , only reason why I block this is that these exclusions SHOULD work and the fact that they don't shows other problem in a Maven command, not in the TS. Why should you care? Basically you are trying to fix failures, but you still running baremetal tests that are not failing or you can if we add new ones that doesn't require unsupported images. Therefore I think this is plain Maven problem and you need to debug it. I can help with debugging, though I think you would manage yourself. Write to the Slack IBM RHBQ channel and we can talk about that. Thanks

redmark-redhat commented 1 month ago

@michalvavrik Yes, the exclusions are working. I was pointing out that we need the DisabledIfSystemProperty to block the Oracle and MSSQL tests in Openshift testing mode. I've removed the -Dtest=!OpenShiftTodoDemoIT so it is no longer in play.

michalvavrik commented 1 month ago

@michalvavrik Yes, the exclusions are working. I was pointing out that we need the DisabledIfSystemProperty to block the Oracle and MSSQL tests in Openshift testing mode. I've removed the -Dtest=!OpenShiftTodoDemoIT so it is no longer in play.

I am getting lost, you provided link, I debugged it and exclusions didn't work for unit tests, so I fixed it here https://github.com/quarkus-qe/quarkus-test-suite/pull/2131. If you need to disable OpenShift tests because there is no image you could use on your system platform, please do it. But it requires adjustments in this PR.

michalvavrik commented 1 month ago

I agree you are disabling tests in a right way if that is what you mean. My comments were regarding only disabling that are unnecessary, but we already concluded that.

michalvavrik commented 1 month ago

@redmark-redhat if you can squash commits, that would be great

redmark-redhat commented 1 month ago

Sure, I have a meeting now but will do it ASAP.

redmark-redhat commented 1 month ago

I'll close the PR and rework fresh and clean on Monday.