quarkus-qe / quarkus-test-suite

16 stars 34 forks source link

Overwrite images also in surefire plugin #2127

Closed mocenas closed 1 month ago

mocenas commented 1 month ago

Summary

In aarch64 and openshift-ibm-z-p-containers profiles, we overwrite image for maven-failsafe plugin. But no images for surefire. Thus tests that are not IT will run with the default images and fail. (I found out about this with AgroalPoolTest on aarch64). This PR should fix that.

No sure what test ibm-z is running, if this is actually beneficial for it. But at least this shouldn't break it.

Please select the relevant options.

Checklist:

michalvavrik commented 1 month ago

No sure what test ibm-z is running, if this is actually beneficial for it. But at least this shouldn't break it.

They should only test OpenShift, because they basically run their tests on Fedora so it's waste of their time that they have baremetal results. We have seen during this release that they actually are running baremetal but it goes down to the wrong mvn command. So I think we should leave IBM Z be.

michalvavrik commented 1 month ago

Anyway, I don't mind changes, it's just for your information.

michalvavrik commented 1 month ago

CI JVM failures are expected due to the MP bump upstream.