search

quarkus-qe / quarkus-test-suite

16 stars 34 forks source link

Switch ValidationHandlerOnRoutes to use SchemaRepository #2192

Open fedinskiy opened 1 week ago

fedinskiy commented 1 week ago

When https://github.com/quarkus-qe/quarkus-test-suite/pull/1516 added vertx validation, it used SchemaParser and SchemaRouter for validation, since Quarkus used the older version of Vertx, but added a TODO to switch it to SchemaRepository later. Now Quarkus uses (https://github.com/quarkusio/quarkus/blob/main/bom/application/pom.xml#L117) Vertx 4.5.10, which have all the necessary features.

fedinskiy commented 1 week ago

Were initially (and erroneously) created here: https://github.com/quarkus-qe/quarkus-test-framework/issues/1332

michalvavrik commented 1 week ago

@fedinskiy I had a look and I think it is too early. While SchemaRepository exists, I can see that in main you can use it to create ValidationHandler https://github.com/vert-x3/vertx-web/blob/master/vertx-web-validation/src/main/java/io/vertx/ext/web/validation/builder/ValidationHandlerBuilder.java#L69 but in 4.5.10 it is still the parser https://github.com/vert-x3/vertx-web/blob/4.5.10/vertx-web-validation/src/main/java/io/vertx/ext/web/validation/builder/ValidationHandlerBuilder.java#L69.