quarkus-qe / quarkus-test-suite

16 stars 34 forks source link

[3.15.2] backports bulk set1 #2212

Closed jcarranzan closed 20 hours ago

jcarranzan commented 4 days ago

Summary

Backport bulk for the following merge requests:

Please select the relevant options.

Checklist:

michalvavrik commented 4 days ago

@jcarranzan I think you didn't check PRs with triage/backport-3.15 labels. Please kindly backport PRs of other people as well.

jcarranzan commented 4 days ago

@jcarranzan I think you didn't check PRs with triage/backport-3.15 labels. Please kindly backport PRs of other people as well.

Sure I can do that. Anyway, there is still some bulk in progress, maybe I will backport all together in a couple of days.

michalvavrik commented 4 days ago

@jcarranzan I think you didn't check PRs with triage/backport-3.15 labels. Please kindly backport PRs of other people as well.

Sure I can do that. Anyway, there is still some bulk in progress, maybe I will backport all together in a couple of days.

CI looks good, I am fine with merging this. It was more like a general note, if you do bulk backport, also backport my PRs! :-)

michalvavrik commented 4 days ago

btw now that I look at it, please us -x option when you do cherry-picks as there is no history in your commit descriptions.

jedla97 commented 4 days ago

As this it targeting 3.15.2, shouldn't some of these test fail? As we have still have 3.15.1 in pom and I don't see update of Quarkus version here.

michalvavrik commented 4 days ago

As this it targeting 3.15.2, shouldn't some of these test fail? As we have still have 3.15.1 in pom and I don't see update of Quarkus version here.

+100, I'd like to see tests failing

jcarranzan commented 3 days ago

As this it targeting 3.15.2, shouldn't some of these test fail? As we have still have 3.15.1 in pom and I don't see update of Quarkus version here.

In pom is <quarkus.platform.version>3.15.999-SNAPSHOT</quarkus.platform.version> I guess pointing last develop upstream quarkus branch (probably already 3.15.2 for that reason tests are not failing) If I execute the tests locally with this option: -Dquarkus.platform.version=3.15.1 then the tests fail as expected. What do you suggest?

jedla97 commented 3 days ago

In pom is 3.15.999-SNAPSHOT</quarkus.platform.version>

Forget about it's build with snapshot. In that case it's ok from my side that test are passing. Thanks for checking it out