search

quarkusio / extensions

The source of https://quarkus.io/extensions
Apache License 2.0
6 stars 4 forks source link

Do not show issue links which redirect to /pulls #1060

Closed holly-cummins closed 3 weeks ago

holly-cummins commented 3 weeks ago

We see intermittent issues being raised, and then closed, for dead links for Debezium and Optaplanner issues. I had some difficulty reproducing locally. I think that explains #633; sometimes, the bad links are not shown, but sometimes they are. I think the intermittency happens because I do the validation in a promise and then set a variable outside the scope of that promise from inside the promise.

The reason we are counting redirects as valid is because that's how url-exists works (but not how linkinator works). For now, I've counted redirects to /pulls as invalid. If we see other redirects, we can decide how to handle them.

Resolves #1059. Resolves #633.

holly-cummins commented 3 weeks ago

Preview URL is https://extensions-quarkus-pr--preview.surge.sh/, so something needs fixing there with the CI scripts (independent of this). https://extensions-quarkus-pr--preview.surge.sh/io.debezium/debezium-quarkus-outbox-reactive/ still has the issues link but I think that's because of the cache.