Open yrodiere opened 8 months ago
Interestingly:
Thank you for pointing this out. Addressed in https://github.com/quarkusio/ja.quarkus.io/pull/1106 for ja.quarkus.io
I thought localized sites were using the same HTML, just with text content replaced with translations, but it would seem that assumption was wrong; some of the HTML gets overridden, too?
For most parts, files are parsed and sentences are replaced automatically, but in some HTML template files, templates contain template directives and they prevent the HTML parser to process the template files. For these template files, we prepare manually translated files(https://github.com/quarkusio/ja.quarkus.io/tree/main/l10n/override/ja_JP) and override the original files to translate them.
Some localized sites that already translated HTML templates are affected, and other localized sites that haven't translated HTML templates are not affected.
Now the search starts working on ja.quarkus.io. Thank you for adding this awesome feature!
Thanks for fixing this!
I'm not sure why, but the changes to https://github.com/quarkusio/quarkusio.github.io/pull/1825 seem to have been taken into account only partially on localized websites. Search on this page doesn't do anything: https://ja.quarkus.io/guides/
I thought localized sites were using the same HTML, just with text content replaced with translations, but it would seem that assumption was wrong; some of the HTML gets overridden, too?
In particular I have this structure on Quarkus.io (and we've had that structure since early last week, so before the last sync):
But on ja.quarkus.io we have this:
See also https://github.com/quarkusio/quarkusio.github.io/blob/317cacbcd097a4f51c7ac4f895c3b9a3759f7cac/guides/index.html#L135-L153 vs. https://github.com/quarkusio/ja.quarkus.io/blob/98dc257bb29ecaeb855542bb7650eca903ceb2ec/docs/guides/index.html#L136-L148
Do you have any idea what's going on, @ynojima?