quarkusio / quarkus-github-bot

A Quarkus-powered GitHub App to simplify issues and pull requests management in the Quarkus project.
Apache License 2.0
23 stars 25 forks source link

Finer-grained of workflow runs, between 'anyone but first-time contributors' and 'only committers' #256

Closed holly-cummins closed 2 years ago

holly-cummins commented 2 years ago

At the moment GitHub only has two options for which PRs will be automatically run on a repository's actions without a manual approval: everyone but first time contributors, or only contributors. This means if someone has a trivial PR accepted, they can run malicious PRs. This is non-ideal on git-hosted runners, and a serious concern on self-hosted runners.

Scrolling down to "Public Repository Warning" in https://www.ideasawakened.com/post/radauthenticator-part-4-build-automation-with-delphi-and-github-by-installing-a-self-hosted-runner has a good discussion of the issue.

Requiring manual approval of runs from everyone but committers will be too onerous, but the bot could apply rules to pre-handle all but ambiguous cases.