quarkusio / quarkus-github-bot

A Quarkus-powered GitHub App to simplify issues and pull requests management in the Quarkus project.
Apache License 2.0
23 stars 24 forks source link

Check pr commits #281

Closed nicolasgras closed 1 year ago

nicolasgras commented 1 year ago

This pull request resolves #236 (Add checks for commits in pull requests) A new feature has been defined to check if PR's commit list contains any merge or fixup commit and check run are created in PR to show results.

image image

gsmet commented 1 year ago

I rebased to remove the merge commits. Believe it or not, we don't want them ;).

I also added a commit with some minor editorialization and dropped the Edited event as we don't want to run the checks just because the description has changed. We might tweak that later if we add more rules.

gsmet commented 1 year ago

Thanks, nice work!

gsmet commented 1 year ago

I just deployed the new version.

nicolasgras commented 1 year ago

My pleasure. Thanks for the review and the merge. :)