search

quarkusio / quarkus-github-bot

A Quarkus-powered GitHub App to simplify issues and pull requests management in the Quarkus project.
Apache License 2.0
23 stars 24 forks source link

include reason for mention/cc #297

Closed maxandersen closed 1 year ago

maxandersen commented 1 year ago

in my constant battle on tuning my ever growing notification inflow I was wondering if this change to quarkus bot would be useful to others:

Instead of just seeing

/cc @gsmet, @manovotn, @maxandersen, @radcortez, @Sanne

on a PR/issue like https://github.com/quarkusio/quarkus/pull/29537 I was thinking to do this:

/cc @gsmet(deps), @manovotn(smallrye), @maxandersen(deps), @radcortez(smallrye), @Sanne(deps)

Letting me know at a faster glance reason why I'm being pinged.

Implementation idea is simply to add optional id to the matchers in quarkus-bot.yaml and whatever id gets matched first add that as reason to a mention.

Could also add all reasons but feels like it could get quite long for some ?

If interesting I can have a stab at it.

gsmet commented 1 year ago

Fixed in https://github.com/quarkusio/quarkus-github-bot/pull/299 .

maxandersen commented 1 year ago

is it live now?

maxandersen commented 1 year ago

ah i see it now - its live. awesomeness.

gsmet commented 1 year ago

Yeah, I pushed it yesterday.