search

quarkusio / quarkus-github-bot

A Quarkus-powered GitHub App to simplify issues and pull requests management in the Quarkus project.
Apache License 2.0
23 stars 24 forks source link

include reason in mention #299

Closed maxandersen closed 1 year ago

maxandersen commented 1 year ago

proposed fix for #297

Only takes effect on rules that has an id attribute and for now I include all potential reasons.

So you can get something like: /cc @maxandersen(deps,jbang), @gsmet(deps), @devtools(jbang),@sanne where maxandersen is notified because he is listening for deps and jbang, gsmet just on deps, devtools for jbang and sanne on one or many rules without an id.

Technically id does not need to be unique...could also be called reason since the code will just merge reasons with same name.

For now just done with issues but similar could be done for pull requests but I can add that.

wdyt?

gsmet commented 1 year ago

I fixed a few minor things but I think it's really nice. I will use the same logic in the pull request and merge.