search

quarkusio / quarkus-github-bot

A Quarkus-powered GitHub App to simplify issues and pull requests management in the Quarkus project.
Apache License 2.0
23 stars 24 forks source link

More neutral icon for skipped jobs (or don't list them at all) #97

Closed famod closed 3 years ago

famod commented 3 years ago

https://github.com/quarkusio/quarkus/pull/16971#issuecomment-832156428

Those red crossed out signs look like failures but they are not. We will see those more often now that my PR is merged that skips most jobs on purpose when they are not affected by changes.

I suggest to use a more neutral greyish version.

gsmet commented 3 years ago

Yeah I wanted that but I haven't found one: https://gist.github.com/rxaviers/7360908 (neither here nor in Unicode). Maybe another symbol would make sense?

The other option would be to use the octicons they use in their table but... it takes a lot more characters and we are very limited.

That being said, now that skipped is a normal behavior, I wonder if we should display them at all.

famod commented 3 years ago

Maybe another symbol would make sense?

🙈? jk! Nah...no good alternative AFAICS.

I wonder if we should display them at all.

Very good point! I think this is the best solution. You can always have a look at the actual workflow summary in case you are interested in skipped jobs.