search

quarkusio / quarkus-http

Apache License 2.0
34 stars 32 forks source link

Ensure client WebSocket connection can always be made #155

Closed geoand closed 5 months ago

geoand commented 5 months ago

This is needed because WebsocketConnectionBuilder might be configured with a non NioEventLoopGroup

Relates to: https://github.com/quarkusio/quarkus/issues/41082

quarkus-bot[bot] commented 5 months ago

Status for workflow Build

This is the status report for running Build on commit 69ec225281856cb0da06e7699a1518e620279d8f.

Failing Jobs

Status Name Step Failures Logs Raw logs
:heavy_check_mark: Build - JDK 11 Logs Raw logs
✖ Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Build - JDK 17 #

- Failing: servlet 
! Skipped: websocket websocket/core websocket/servlet and 1 more

:package: servlet

✖ io.undertow.servlet.test.dispatcher.DispatcherForwardTestCase.testPathBasedInclude line 137 - More details - Source on GitHub

``` org.junit.ComparisonFailure: expected:<...etContext/dispatch /[dispatch]> but was:<...etContext/dispatch /[forward]> at org.junit.Assert.assertEquals(Assert.java:117) at org.junit.Assert.assertEquals(Assert.java:146) at io.undertow.servlet.test.dispatcher.DispatcherForwardTestCase.testPathBasedInclude(DispatcherForwardTestCase.java:137) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) ```
geoand commented 5 months ago

I am pretty sure the test failure has nothing to do with this change

geoand commented 5 months ago

I have verified that the CI failure is present in main as well.