search

quarkusio / quarkus-http

Apache License 2.0
31 stars 31 forks source link

Ability to set MAX_PARAMETERS in Undertow #63

Closed benkard closed 3 years ago

benkard commented 3 years ago

When using Undertow, a request with more than 1,000 parameters triggers a io.undertow.util.ParameterLimitException. While that's a reasonable default, I have a need to configure it. (A JSF application I am porting to Quarkus via the MyFaces Quarkus extension generates very large requests.)

Undertow provides a way of providing it with an UndertowOptionMap, one key of which is MAX_PARAMETERS. It would be nice if there were a way of setting it through application.properties.

stuartwdouglas commented 3 years ago

https://github.com/quarkusio/quarkus-http/commit/00223f28f17a246a3075b3f1ce38dc289976a641

Once this is released it will need some code to wire it up in Quarkus

benkard commented 3 years ago

Wow, that was super fast. Thank you!

benkard commented 3 years ago

Here's a start on the Quarkus side: https://github.com/benkard/quarkus/commit/12dde7db9b7c06992bd1c6f8a57b5dda379d5596

Still need to add a test or two before I open a PR.