search

quarkusio / quarkus-images

Set of container images delivered for Quarkus
Apache License 2.0
110 stars 75 forks source link

Add multi-arch native image and Mandrel image push steps #196

Closed galderz closed 1 year ago

galderz commented 2 years ago

This should close #83, but I think we'll only know if it really works once integrated and we try to push the images. @cescoffier?

/cc @zakkak Clement had suggested that maybe push images script should become a jbang script. WDYT?

edeandrea commented 2 years ago

@galderz I'm happy to test this with the Quarkus superheroes once there are multi-arch images available somewhere. As I mentioned on #83 I already have the scaffolding & wiring in place. All I need are quay.io/quarkus/ubi-quarkus-mandrel and quay.io/quarkus/quarkus-micro-image images that have both amd64 & arm64 platforms available.

galderz commented 2 years ago

@edeandrea No work has been done here to add multi arch support for quarkus-micro-image. This PR and https://github.com/quarkusio/quarkus-images/pull/195 focused on adding multi-arch support for GraalVM and Mandrel container images.

edeandrea commented 2 years ago

Thanks @galderz . Does that mean in the interim I'd have to switch back to the Dockerfile that uses FROM registry.access.redhat.com/ubi8/ubi-minimal:8.5?

galderz commented 2 years ago

Thanks @galderz . Does that mean in the interim I'd have to switch back to the Dockerfile that uses FROM registry.access.redhat.com/ubi8/ubi-minimal:8.5?

Switch what?

edeandrea commented 2 years ago

A Dockerfile that uses the quarkus-micro-image as it's base image (like https://github.com/quarkusio/quarkus-super-heroes/blob/main/rest-villains/src/main/docker/Dockerfile.native#L20)

galderz commented 2 years ago

Hmmmm, yeah, I guess you could change FROM to registry.access.redhat.com/ubi8/ubi-minimal:8.5 and then do things manually yourself if needed. I don't know anything about quarkus-micro-image TBH.

edeandrea commented 2 years ago

I'll do that once your work on the ubi-mandrel image is done and those images are available.

galderz commented 1 year ago

This work won't be integrated as is. The partial work in master is not fully working as expected. An effort is ongoing to provide a better solution.