quarkusio / quarkus-images

Set of container images delivered for Quarkus
Apache License 2.0
110 stars 75 forks source link

multi-arch images missing manifest list? #199

Closed edeandrea closed 1 year ago

edeandrea commented 2 years ago

I see on https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags (as well as some of the other images on quay.io/quarkus) there are multi-arch images, but I don't see a manifest list that combines the images.

As it is now I have to specify a specific image tag for amd64 vs arm64 instead of just saying quay.io/quarkus/ubi-quarkus-mandrel:22.0-java17 and let it figure out which platform to build.

For example, from https://quay.io/repository/quarkus-super-heroes/rest-villains?tab=tags

image

cescoffier commented 2 years ago

@edeandrea we are working on a new approach to produce multi-arch images. The current approach is not convenient (and upx does not have the right arch)

edeandrea commented 2 years ago

Until thats works out, the manifest could be created with a simple command:

docker manifest create quay.io/quarkus/ubi-quarkus-mandrel:22.0-java17 \
  -a quay.io/quarkus/ubi-quarkus-mandrel:22.0-java17-amd64 \
  -a quay.io/quarkus/ubi-quarkus-mandrel:22.0-java17-arm64

docker manifest push quay.io/quarkus/ubi-quarkus-mandrel:22.0-java17

This would be a huge step and something that could be added to the end of whatever CI process is currently in place that is producing the images?

cescoffier commented 2 years ago

Try with https://quay.io/repository/cescoffi/ubi-quarkus-mandrel?tab=tags. (this is produced with the new approach).

We cannot add your line to the CI, the script fails before that....

cescoffier commented 1 year ago

Fixed.