search

quarkusio / quarkus-platform-bom-generator

Quarkus platform BOM generating tools
Apache License 2.0
9 stars 18 forks source link

Test artifacts version should be equal to the version of the test list #91

Open ppalaga opened 2 years ago

ppalaga commented 2 years ago

This was not supposed to work before 0.0.32, so I implemented this workaround in the XSL:

I tested again with 0.0.37, and IMO it still does not work. Maybe I am doing something wrong.

This is what I am doing:

  1. Initial state (the one containing the workaround) is commit b2f3adb2055f500346842f31c528493ef0c0ea27 from this branch: https://github.com/ppalaga/quarkus-platform/commits/i91
  2. Remove the workaround in the XSL: https://github.com/ppalaga/quarkus-platform/commit/11815a1c51518f262c7444ba52aa3641e7a6d7d7#diff-83ce56bfbc63c6c743ed24689a3e000a2a06e2857c874c85c82b9ca19149c73aL52
  3. Regenerate the BOMs via mvn clean install -DskipTests -Prhproduct -Denforcer.skip

EXPECTED: Either no change in the generated tests like this one https://github.com/ppalaga/quarkus-platform/commit/11815a1c51518f262c7444ba52aa3641e7a6d7d7#diff-5046a7d2bf1acb6e6f9c6049180329b7fdb3a06e2f39d28345776aad6df1df06L15-R15 or only changes do not cause the tests fail. Expected is that all test artifacts have the community version , ${camel-quarkus-tests.version} set in the rhproduct profile.

ACTUAL: Test artifacts in the generated test modules have ${camel-quarkus.version}. That's the productized version for the rhproduct profile. Some Camel Quarkus Test artifacts do not exist in this version (because they were intentionally not productized) and thus some tests cannot be compiled.

ppalaga commented 2 years ago

OK, I see this should be fixed since version 0.0.42 https://github.com/quarkusio/quarkus-platform-bom-generator/pull/73

ppalaga commented 2 years ago

I tried with 0.0.42 and it still does not work. Same steps as above.