search

quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.93k stars 1.43k forks source link

kogito-quickstart and kogito-drl-quickstart are failing with Quarkus main #1126

Open rsvoboda opened 2 years ago

rsvoboda commented 2 years ago

kogito-quickstart and kogito-drl-quickstart are failing with Quarkus main

Troubles are around javaparser version introduced to Quarkus main repo in https://github.com/quarkusio/quarkus/commit/9c68d21992d2cf2c777edab25807b6493bc01e07

Discussion started in https://github.com/quarkusio/quarkus/issues/6588#issuecomment-1154716836

Some changes went into https://github.com/kiegroup/drools/commit/b93bd100b86b7b8863cea6009e8def71dbc4f463 and https://github.com/kiegroup/kogito-runtimes/commit/8661e959f59f9fdbe7a61f7774a38b4d1d7ea6bf

I checked the commits and the version update commit is just for main, not for 1.23 branch (assuming 1.23 is the next planned release)

FAIL -- mvn clean verify -f kogito-quickstart -Dkogito.platform.version=1.23.0-SNAPSHOT PASS -- mvn clean verify -f kogito-quickstart -Dkogito.platform.version=2.0.0-SNAPSHOT

Another issue with kogito quickstarts is old kogito bom version from March (1.19.0.Final), e.g. https://github.com/quarkusio/quarkus-quickstarts/blob/main/kogito-quickstart/pom.xml#L17 / https://github.com/quarkusio/quarkus-quickstarts/blob/main/kogito-drl-quickstart/pom.xml#L22

CC @mariofusco / @cescoffier / @gsmet

rsvoboda commented 2 years ago

CC @evacchi

evacchi commented 2 years ago

that's weird I think the branch was cut after mario merged, and it was on drools anyway (a snapshot dependency for kogito) maybe you haven't tried the latest drools snapshot (i.e. Nexus being silly) ? /cc @mariofusco

rsvoboda commented 2 years ago

https://github.com/kiegroup/kogito-runtimes/blob/1.23.x/kogito-build/kogito-dependencies-bom/pom.xml -- <version.com.github.javaparser>3.23.1</version.com.github.javaparser>

<version.com.github.javaparser>3.24.2</version.com.github.javaparser> is used in main

evacchi commented 2 years ago

my mistake @rsvoboda the version with the fix will be 1.24

rsvoboda commented 2 years ago

When is going to be released?

Is there any workaround to be applied to the quickstarts or they should be disabled till the version 1.24 gets out?

evacchi commented 2 years ago

we'll try to release 1.23.1 with the fix; in the meantime we can disable them /cc @mariofusco

rsvoboda commented 2 years ago

+1 to disable them before 1.23.1 is out

evacchi commented 2 years ago

@radtriste how is progress on this?

radtriste commented 2 years ago

@evacchi the tests were disabled AFAIK we are waiting for 1.24 release to reenable them. This should happen end of this week, beginning of the next week. There was just a week between 1.23.1 and 1.24 so we decided not to release the 1.23.1 and focus on the big changes of 1.24.

evacchi commented 2 years ago

thx for the update 👍

rsvoboda commented 2 years ago

@evacchi @radtriste tests in kogito and kogito-drl-quickstart quickstarts are not disabled

see for example https://github.com/quarkusio/quarkus-quickstarts/blob/development/kogito-quickstart/src/test/java/org/acme/kogito/PersonProcessTest.java and https://github.com/quarkusio/quarkus/issues/6588

radtriste commented 2 years ago

@evacchi @radtriste tests in kogito and kogito-drl-quickstart quickstarts are not disabled

see for example https://github.com/quarkusio/quarkus-quickstarts/blob/development/kogito-quickstart/src/test/java/org/acme/kogito/PersonProcessTest.java and quarkusio/quarkus#6588

sorry I meant on platform as we had similar issues. we need to act indeed on quickstarts ...

evacchi commented 2 years ago

this should disable the offending tests, apologies for the wait https://github.com/quarkusio/quarkus-quickstarts/pull/1132

evacchi commented 2 years ago

update: the PR did not solve the crash, @rsvoboda has removed the quickstarts entirely from the build for now