getting-started: Clean up s2i/environment

[jmtd]

Here we remove some environment variable definitions from .s2i/environment which used to be necessary for the Red Hat OpenJDK container images to work correctly with the default Quarkus "fast-jar" package type. The drawback of defining these variables is that the quickstart now only works for the fast-jar layout, and would break if the user specifies another via QUARKUS_PACKAGE_TYPE, unless they realise .s2i/environment (a hidden file) exists, and either alter it or override the other variables within.

The RH OpenJDK container image works with fast-jar OOTB since :1.17 (2023-08-28).

Whilst I was in there, I removed AB_JOLOKIA_OFF, which is not needed for the JDK17 or JDK21 images; and changed JAVA_OPTIONS to JAVA_OPTS_APPEND, which I think has the desired semantics. That last change in particular I would like some feedback on:

• is the intention really to append to, and not override, the container run script's JVM tuning? (I'd recommend appending)
• do you still need/want to specify -Dquarkus.http.host=0.0.0.0? If not, we could delete the file entirely, which would be nice because it's not very discoverable
• are you concerned with any other containers or run scripts in an S2I context, besides the RH OpenJDK images?

Check list:

Your pull request:

• [X] targets the development branch
• [X] uses the 999-SNAPSHOT version of Quarkus
• [ ] has tests (mvn clean test)
• [X] works in native (mvn clean package -Pnative)
• [ ] has integration/native tests (mvn clean verify -Pnative)
• [ ] makes sure the associated guide must not be updated
• [ ] links the guide update pull request (if needed)
• [ ] updates or creates the README.md file (with build and run instructions) N/A
• [ ] for new quickstart, is located in the directory component-quickstart N/A
• [ ] for new quickstart, is added to the root pom.xml and README.md N/A

[cescoffier]

Can you open the PR against the development branch instead of main?

[jmtd]

Can you open the PR against the development branch instead of main?

Sure, I'll rebase now (done in ac1eadc866bc3dbba41b90eaba5285dd0e55058c); but as I said, this quickstart appears to be failing in development right now, before my patches, so it's harder to verify:

I1211 12:32:03.697855  112432 sti.go:713] [ERROR]     'dependencies.dependency.version' for io.quarkus:quarkus-resteasy-reactive:jar is missing. @ line 34, column 21
I1211 12:32:03.697896  112432 sti.go:713] [ERROR]     'dependencies.dependency.version' for io.quarkus:quarkus-junit5:jar is missing. @ line 38, column 21
I1211 12:32:03.697954  112432 sti.go:713] [ERROR]     'dependencies.dependency.version' for io.rest-assured:rest-assured:jar is missing. @ line 43, column 21

or perhaps that's expected on dev branch? Since 999-SNAPSHOT is a placeholder? Edit: ah, once I've built quarkus master branch (not development) I have the necessary artefacts locally to run mvn verify etc.

[jmtd]

Can anyone take a look at this please?