quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.95k stars 1.45k forks source link

Prepare quickstarts to renamings in 3.9 #1393

Closed gsmet closed 6 months ago

gsmet commented 6 months ago

Draft for now as we still need to merge the SmallRye Reactive Messaging stuff.

quarkus-bot[bot] commented 6 months ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 5fe528590c8bc089b4e048fa6705f63c7d693a74.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven :warning: Check → Logs Raw logs
quarkus-bot[bot] commented 6 months ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 977f84ef605dfa6453e598e48c7280fb6843dd83.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Failures

:gear: Build - JDK 17 #

- Failing: messaging-http-quickstart messaging-websockets-quickstart 

:package: messaging-http-quickstart

Failed to execute goal on project reactive-messaging-http-quickstart: Could not resolve dependencies for project org.acme:reactive-messaging-http-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-smallrye-reactive-messaging:jar:999-SNAPSHOT

:package: messaging-websockets-quickstart

Failed to execute goal on project reactive-messaging-websockets-quickstart: Could not resolve dependencies for project org.acme:reactive-messaging-websockets-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-smallrye-reactive-messaging:jar:999-SNAPSHOT

quarkus-bot[bot] commented 6 months ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 5fe528590c8bc089b4e048fa6705f63c7d693a74.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Failures

:gear: Build - JDK 17 #

- Failing: messaging-http-quickstart messaging-websockets-quickstart 

:package: messaging-http-quickstart

Failed to execute goal on project reactive-messaging-http-quickstart: Could not resolve dependencies for project org.acme:reactive-messaging-http-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-smallrye-reactive-messaging:jar:999-SNAPSHOT

:package: messaging-websockets-quickstart

Failed to execute goal on project reactive-messaging-websockets-quickstart: Could not resolve dependencies for project org.acme:reactive-messaging-websockets-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-smallrye-reactive-messaging:jar:999-SNAPSHOT

yrodiere commented 6 months ago

Restarting CI now that Smallrye Reactive messaging was renamed too

quarkus-bot[bot] commented 6 months ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 977f84ef605dfa6453e598e48c7280fb6843dd83.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Failures

:gear: Build - JDK 17 #

- Failing: messaging-http-quickstart messaging-websockets-quickstart 

:package: messaging-http-quickstart

Failed to execute goal on project reactive-messaging-http-quickstart: Could not resolve dependencies for project org.acme:reactive-messaging-http-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-smallrye-reactive-messaging:jar:999-SNAPSHOT

:package: messaging-websockets-quickstart

Failed to execute goal on project reactive-messaging-websockets-quickstart: Could not resolve dependencies for project org.acme:reactive-messaging-websockets-quickstart:jar:1.0.0-SNAPSHOT: Could not find artifact io.quarkus:quarkus-smallrye-reactive-messaging:jar:999-SNAPSHOT

gsmet commented 6 months ago

Mmmmh, we need other versions of these Quarkiverse projects...

Really we should move Quarkiverse quickstarts out of the main quickstarts repo to their Quarkiverse home.

@ozangunalp could you help release new versions of these Reactive Messaging Quarkiverse extensions pointing to the new artifacts? The quickstart repo is not relying on relocations to make sure we use the appropriate artifacts.

gsmet commented 6 months ago

@ozangunalp or we decide to move these quickstarts to the extensions? I did that for some of the extensions I moved to Quarkiverse and I think that's better.

gsmet commented 6 months ago

See https://github.com/quarkiverse/quarkus-smallrye-opentracing for an example.

ozangunalp commented 6 months ago

See https://github.com/quarkiverse/quarkus-smallrye-opentracing for an example.

@gsmet Thanks, I'll do that. I think reactive-messaging-websockets and reactive-messaging-http are the only ones.

quarkus-bot[bot] commented 6 months ago

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 459a4e0060b18d4a90cdaca460b249d384f23ed2.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

ozangunalp commented 6 months ago

reactive-messaging-websockets and reactive-messaging-http quickstarts moved in : https://github.com/quarkiverse/quarkus-reactive-messaging-http/pull/244

gsmet commented 6 months ago

@ozangunalp I didn't see any reference to them in the doc of the core repository so I think we are fine.

Maybe check the doc of the extensions in the Quarkiverse project as the links might be there.

ozangunalp commented 6 months ago

@gsmet Yes I need to adjust the Quarkiverse extension docs.