quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.92k stars 1.43k forks source link

Dependency addition needed by Flyway 10 #1398

Closed rsvoboda closed 3 months ago

rsvoboda commented 3 months ago

Dependency addition needed by Flyway 10

Your pull request:

quarkus-bot[bot] commented 3 months ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 88f305a52de853f213ca3807cfdc5433e83b3e65.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

gsmet commented 3 months ago

We will have to wait until 3.9 is released to merge this one. Unless we backport Flyway 10 to 3.9 but people don't look that excited about the idea.

gsmet commented 3 months ago

Rebased as I wanted to get a full CI run for other purposes.

quarkus-bot[bot] commented 3 months ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit e70870dd67b8970535b84ab20d957093142a0c79.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Build - JDK 17 #

- Failing: security-openid-connect-multi-tenancy-quickstart 

:package: security-openid-connect-multi-tenancy-quickstart

org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants line 89 - More details - Source on GitHub

``` org.opentest4j.AssertionFailedError: expected: but was: <> at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145) at org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants(CodeFlowTest.java:89) ```
rsvoboda commented 3 months ago

@gsmet can be this merged now?

https://github.com/quarkusio/quarkus-quickstarts/tree/3.9 was created

rsvoboda commented 3 months ago

Rebasing to pick the latest changes

quarkus-bot[bot] commented 3 months ago

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 71e037005a602244c128815de9aee19b76d4236f.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Build - JDK 17 #

- Failing: security-openid-connect-multi-tenancy-quickstart 

:package: security-openid-connect-multi-tenancy-quickstart

org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants line 89 - More details - Source on GitHub

``` org.opentest4j.AssertionFailedError: expected: but was: <> at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145) at org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants(CodeFlowTest.java:89) ```
gsmet commented 3 months ago

@sberyozkin @michalvavrik this CodeFlowTest looks concerning to me ^

michalvavrik commented 3 months ago

@sberyozkin @michalvavrik this CodeFlowTest looks concerning to me ^

Sergey did fixes (I won't look for the PR, it's the one with the cookie resolution), tenant a is selected instead of the default one because there is a cookie session io.quarkus.oidc.runtime.OidcAuthenticationMechanism#setTenantIdAttribute(io.vertx.ext.web.RoutingContext). Problem is that convention resolver should have a priority (path end withs /default). My best guess would be that TENANT_ID_ATTRIBUTE but it isn't the value of the default one because we don't set that null there @sberyozkin ? Anyway, I didn't debug it properly because Sergey has been into this in last week, he should have a look.