Closed rsvoboda closed 3 months ago
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Pull Request Build - development
This is the status report for running Pull Request Build - development
on commit 88f305a52de853f213ca3807cfdc5433e83b3e65.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
We will have to wait until 3.9 is released to merge this one. Unless we backport Flyway 10 to 3.9 but people don't look that excited about the idea.
Rebased as I wanted to get a full CI run for other purposes.
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Pull Request Build - development
This is the status report for running Pull Request Build - development
on commit e70870dd67b8970535b84ab20d957093142a0c79.
Status | Name | Step | Failures | Logs | Raw logs |
---|---|---|---|---|---|
✖ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
- Failing: security-openid-connect-multi-tenancy-quickstart
✖ org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants
line 89
- More details - Source on GitHub
@gsmet can be this merged now?
https://github.com/quarkusio/quarkus-quickstarts/tree/3.9 was created
Rebasing to pick the latest changes
Pull Request Build - development
This is the status report for running Pull Request Build - development
on commit 71e037005a602244c128815de9aee19b76d4236f.
Status | Name | Step | Failures | Logs | Raw logs |
---|---|---|---|---|---|
✖ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
- Failing: security-openid-connect-multi-tenancy-quickstart
✖ org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants
line 89
- More details - Source on GitHub
@sberyozkin @michalvavrik this CodeFlowTest
looks concerning to me ^
@sberyozkin @michalvavrik this
CodeFlowTest
looks concerning to me ^
Sergey did fixes (I won't look for the PR, it's the one with the cookie resolution), tenant a is selected instead of the default one because there is a cookie session io.quarkus.oidc.runtime.OidcAuthenticationMechanism#setTenantIdAttribute(io.vertx.ext.web.RoutingContext)
. Problem is that convention resolver should have a priority (path end withs /default
). My best guess would be that TENANT_ID_ATTRIBUTE
but it isn't the value of the default one because we don't set that null there @sberyozkin ? Anyway, I didn't debug it properly because Sergey has been into this in last week, he should have a look.
Dependency addition needed by Flyway 10
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md