quarkusio / quarkus-quickstarts

Quarkus quickstart code
https://quarkus.io
Apache License 2.0
1.92k stars 1.43k forks source link

fix: download file method should have byte[] as response content #1400

Closed petro1 closed 3 months ago

petro1 commented 3 months ago

fix: download file method should have byte[] as response content

scrocquesel commented 3 months ago

@gsmet LGTM

quarkus-bot[bot] commented 3 months ago

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit afbe5e1c31f57fcfac3233992ce5f407f3cf160d.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

:gear: Build - JDK 17 #

- Failing: hibernate-orm-multi-tenancy-quickstart quartz-quickstart security-openid-connect-multi-tenancy-quickstart 

:package: hibernate-orm-multi-tenancy-quickstart

org.acme.hibernate.orm.FruitsEndpointTest.testListAllFruitsBaseSchema - More details - Source on GitHub

``` java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:643) at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:727) at java.base/java.util.Optional.orElseGet(Optional.java:364) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) Caused by: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) ```

:package: quartz-quickstart

org.acme.quartz.TaskResourceTest.tasks - More details - Source on GitHub

``` java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:643) at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:727) at java.base/java.util.Optional.orElseGet(Optional.java:364) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) Caused by: java.lang.RuntimeException: Failed to start quarkus at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) ```

:package: security-openid-connect-multi-tenancy-quickstart

org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants line 89 - More details - Source on GitHub

``` org.opentest4j.AssertionFailedError: expected: but was: <> at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177) at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145) at org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants(CodeFlowTest.java:89) ```
petro1 commented 3 months ago

I see the jdk build failed, what can we do here? Thanks.

gsmet commented 3 months ago

It's unrelated. We have some issues because CI tries to build with Quarkus main and these quickstarts are still based on 3.9. Thanks for the PR!